Applying improvements selected from IcehrmPro for release v21.0.0

admin/settings/index.php

@@ -37,9 +37,11 @@ $moduleBuilder->addModuleOrGroup(new \Classes\ModuleBuilder\ModuleTab(
 $moduleBuilder->addModuleOrGroup(new \Classes\ModuleBuilder\ModuleTab(
     'SystemSetting','Setting','System','SettingAdapter','{"name":["System:"]}','name',false,$options1
 ));
-$moduleBuilder->addModuleOrGroup(new \Classes\ModuleBuilder\ModuleTab(
-    'EmailSetting','Setting','Email','SettingAdapter','{"name":["Email:"]}','name',false,$options1
-));
+if (!defined('CLOUD_INSTALLATION')) {
+    $moduleBuilder->addModuleOrGroup(new \Classes\ModuleBuilder\ModuleTab(
+        'EmailSetting', 'Setting', 'Email', 'SettingAdapter', '{"name":["Email:"]}', 'name', false, $options1
+    ));
+}
 $moduleBuilder->addModuleOrGroup(new \Classes\ModuleBuilder\ModuleTab(
     'LeaveSetting','Setting','Leave / PTO','SettingAdapter','{"name":["Leave:"]}','name',false,$options1
 ));

api/Base.js

@@ -2461,9 +2461,10 @@ IceHRMBase.method('clearFileElement', function (elementName) {
 
 IceHRMBase.method('fixJSON', function (json) {
 	if(this.noJSONRequests == "1"){
-		json = json.replace(/"/g,'|');
+		json = window.btoa(json);
 	}
 	return json;
+
 });
 
 

build.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project name="icehrm-opensource" default="build">
+<project name="icehrm-pro" default="build">
  <!-- By default, we assume all tools to be on the $PATH -->
  <property name="toolsdir" value="${basedir}/tools/"/>
  <property name="destination" value="${basedir}/build/app"/>

config.base.php

@@ -13,10 +13,10 @@ if(!defined('HOME_LINK_OTHERS')){
 }
 
 //Version
-define('VERSION', '20.3.0.OS');
-define('CACHE_VALUE', '20.3.0.OS');
-define('VERSION_NUMBER', '2030');
-define('VERSION_DATE', '26/11/2017');
+define('VERSION', '21.0.0.PRO');
+define('CACHE_VALUE', '21.0.0.OS');
+define('VERSION_NUMBER', '2100');
+define('VERSION_DATE', '02/02/2018');
 
 if(!defined('CONTACT_EMAIL')){define('CONTACT_EMAIL','icehrm@gamonoid.com');}
 if(!defined('KEY_PREFIX')){define('KEY_PREFIX','IceHrm');}

header.php

@@ -20,7 +20,9 @@ along with Ice Framework. If not, see <http://www.gnu.org/licenses/>.
 Original work Copyright (c) 2012 [Gamonoid Media Pvt. Ltd]
 Developer: Thilina Hasantha (thilina.hasantha[at]gmail.com / facebook.com/thilinah)
  */
-
+if (!defined('MODULE_NAME')) {
+    define('MODULE_NAME', $moduleName);
+}
 include 'includes.inc.php';
 if(empty($user)){
     $actual_link = "http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";

lib/composer/composer.json

@@ -5,12 +5,12 @@
         "gettext/gettext": "4.0.0",
         "consolidation/robo": "~1",
         "filp/whoops": "~2.1",
-        "swiftmailer/swiftmailer": "^6",
-		"pear/net_smtp": "~1.7",
-		"pear/mail": "~1.4"
+        "swiftmailer/swiftmailer": "^6.0",
+		"pear/net_smtp": "^1.7",
+		"pear/mail": "^1.4"
     },
     "require-dev": {
-      "phpunit/phpunit": "~6.5.5"
+      "phpunit/phpunit": "~6"
 	},
     "autoload": {
       "psr-4": {

migrations/v20171126_200303_swift_mail.php

@@ -10,11 +10,11 @@ class v20171126_200303_swift_mail extends AbstractMigration{
 		$setting = new Setting();
 		$setting->Load("name = ?", array('Email: Mode'));
 		if(!empty($setting->id)){
-			$setting->description = 'Require submitting a photo using web cam when marking attendance';
+			$setting->description = 'Update email sender';
 			$setting->meta = '["value", {"label":"Value","type":"select","source":[["SMTP","SMTP"],["Swift SMTP","Swift SMTP"],["PHP Mailer","PHP Mailer"],["SES","Amazon SES"]]}]';
 			$setting->Save();
 		}
-		
+
 		return true;
 	}
 

release.md

@@ -1,5 +1,14 @@
-Release note v20.3.0.OS
------------------------
+Release note v21.0.0.OS
+------------------------
+### Features
+ * Fully compatible with php 7.1
+ * Add Net_SMTP via composer (no pear installation needed)
+ 
+### Fixes
+ * Fixes for web servers not supporting JSON in GET request
+ 
+Release note v20.3.0.PRO
+------------------------
 ### Features
  * Employee and Attendance REST Api Released
  * Import/Export for Payroll Configurations

src/Classes/BaseService.php

@@ -1407,7 +1407,7 @@ class BaseService
     {
         $noJSONRequests = SettingsManager::getInstance()->getSetting("System: Do not pass JSON in request");
         if ($noJSONRequests."" == "1") {
-            $json = str_replace("|", '"', $json);
+            $json = base64_decode($json);
         }
         return $json;
     }

src/Utils/CalendarTools.php

@@ -49,11 +49,19 @@ class CalendarTools
         return $days;
     }
 
-    public static function addMinutesToDateTime($datetime, $minutes)
+    public static function addMinutesToDateTime($datetime, $minutes, $format = 'Y-m-d H:i:s')
     {
         $time = new \DateTime($datetime);
-        $time->add(new \DateInterval('PT' . $minutes . 'M'));
+        $time = $time->add(new \DateInterval('PT' . $minutes . 'M'));
 
-        return $time->format('Y-m-d H:i:s');
+        return $time->format($format);
+    }
+
+    public static function addMonthsToDateTime($datetime, $months, $format = 'Y-m-d H:i:s')
+    {
+        $time = new \DateTime($datetime);
+        $time = $time->add(new \DateInterval('P' . $months . 'M'));
+
+        return $time->format($format);
     }
 }

src/Utils/SessionUtils.php

@@ -23,7 +23,7 @@ class SessionUtils
         session_write_close();
     }
 
-    public function unsetClientSession()
+    public static function unsetClientSession()
     {
         $names = [
             "user",