Upgrades from IceHrm Pro v24

core/src/Employees/Admin/Api/EmployeesActionManager.php

@@ -33,6 +33,9 @@ class EmployeesActionManager extends SubActionManager
     public function terminateEmployee($req)
     {
         $employee = new Employee();
+
+        $this->baseService->checkSecureAccess('delete', $employee, 'Employee', $_POST);
+
         $employee->Load("id = ?", array($req->id));
 
         if (empty($employee->id)) {
@@ -48,8 +51,6 @@ class EmployeesActionManager extends SubActionManager
         }
 
         return new IceResponse(IceResponse::SUCCESS, $employee);
-
-        //$user = BaseService::getInstance()->getUserFromProfileId($employee->id);
     }
 
     public function activateEmployee($req)
@@ -70,8 +71,6 @@ class EmployeesActionManager extends SubActionManager
         }
 
         return new IceResponse(IceResponse::SUCCESS, $employee);
-
-        //$user = BaseService::getInstance()->getUserFromProfileId($employee->id);
     }
 
     public function deleteEmployee($req)

core/src/Employees/Common/Model/Employee.php

@@ -213,5 +213,9 @@ class Employee extends BaseModel
         return $obj;
     }
 
+    public function fieldValueMethods() {
+        return ['getActiveSubordinateEmployees'];
+    }
+
     public $table = 'Employees';
 }

core/src/Employees/Common/Model/EmploymentStatus.php

@@ -24,9 +24,4 @@ class EmploymentStatus extends BaseModel
     {
         return array("get","element","save");
     }
-
-    public function getUserAccess()
-    {
-        return array();
-    }
 }